Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider writing analyzed.toml file #21

Closed
natalieparellano opened this issue Jun 25, 2024 · 1 comment · Fixed by #22
Closed

Consider writing analyzed.toml file #21

natalieparellano opened this issue Jun 25, 2024 · 1 comment · Fixed by #22

Comments

@natalieparellano
Copy link

I noticed that you are skipping the analyze phase, which for now is probably okay as we fallback to reading /etc/os-release during detect, which will give us distro information for target matching. So, the lifecycle is not going to hard-fail buildpacks during detect for target mismatch.

However, some buildpacks may start to inspect the CNB_TARGET_* env vars that they get during detect (I believe Heroku’s buildpacks are starting to do this although Paketo is not yet there), and opt out of the build if the value is missing or unexpected. It would be safer to pre-write an analyzed.toml file with the expected target data for the run “image” to avoid surprises.

@pbusko
Copy link
Contributor

pbusko commented Jun 26, 2024

Thank you @natalieparellano for reporting this. We skipped the analyze phase completely because there's actually no images to analyse (neither previous nor run image), as the produced result is a Droplet.

However we completely missed the CNB_TARGET_* part, will be fixed in #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants