Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEEDBACK: red or green dot on DO services #7009

Closed
isaac-mcfadyen opened this issue Oct 17, 2024 · 2 comments · Fixed by #7039
Closed

FEEDBACK: red or green dot on DO services #7009

isaac-mcfadyen opened this issue Oct 17, 2024 · 2 comments · Fixed by #7039

Comments

@isaac-mcfadyen
Copy link
Contributor

isaac-mcfadyen commented Oct 17, 2024

In PR #6893, a red or green dot was added beside each service when deploying a DO with Wrangler.

I'm not too familiar with Wrangler internals, but it looks like the red vs. green is decided based on whether a service is in the registry.

Per some feedback on Discord, this isn't really clear to users, and in fact the random red dot can be kind of concerning given that there is no explanation on what it means or why your services are suddenly red.

I believe it was added in PR #6893:

value += ` (defined in 🔴 ${script_name})`;

@AdiRishi
Copy link

Just wanted to clarify something here (I'm the OP on discord).
I didn't encounter this while deploying a DO with wrangler, but rather a worker with static assets (Remix website) with 3 bound JSRPC workers (not sure if that's the same as DO underneath)

  Total Upload: 3324.79 KiB / gzip: 1022.32 KiB
  Worker Startup Time: 235 ms
  Your worker has access to the following bindings:
  - KV Namespaces:
    - CACHIFIED_CACHE: 191f201005724b038b6facd2ae37e1d9
  - Services:
    - PUBLIC_DATA_SERVICE: 🔴 naamdeo-courses-api#PublicDataService
    - AUTHENTICATED_USER_SERVICE: 🔴 naamdeo-courses-api#AuthenticatedUserService
    - RESTRICTED_SERVICE: 🔴 naamdeo-courses-api#RestrictedService

@penalosa penalosa linked a pull request Oct 21, 2024 that will close this issue
9 tasks
@lrapoport-cf lrapoport-cf moved this from Untriaged to Backlog in workers-sdk Oct 21, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in workers-sdk Oct 21, 2024
@isaac-mcfadyen
Copy link
Contributor Author

Hey @penalosa,

Thanks for PR #7039

While that's definitely a fix for non-local dev, I believe in local dev there's still no indication of what the red/green dots actually mean? Users aren't going to know about the registry, just that there's a random indicator beside their services that isn't explained anywhere that I can find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants