Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace online API mocks with local API mocks in unit tests #100

Open
sivachandran opened this issue Mar 18, 2021 · 0 comments · May be fixed by #103
Open

Replace online API mocks with local API mocks in unit tests #100

sivachandran opened this issue Mar 18, 2021 · 0 comments · May be fixed by #103
Labels
code quality

Comments

@sivachandran
Copy link
Contributor

Presently, multiple unit tests are depending on online API mocks to test the functionalities. Online API mocks make stable Internet a requirement for the unit tests which is not desired. The codebase should be testable even if there is no Internet. So, the unit tests that use online API mocks should be changed to use local API mocks in their testing.
@sivachandran sivachandran linked a pull request Mar 24, 2021 that will close this issue
Changes to use mocks in tests #103
Open
@sivachandran sivachandran linked a pull request Mar 24, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes to use mocks in tests sivachandran/clamp-core
1 participant
@sivachandran