Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the scriptsig for the Notebook P2WPKH on Chapter 2 #39

Open
MPins opened this issue Dec 26, 2024 · 0 comments
Open

Fixing the scriptsig for the Notebook P2WPKH on Chapter 2 #39

MPins opened this issue Dec 26, 2024 · 0 comments

Comments

@MPins
Copy link
Contributor

MPins commented Dec 26, 2024

The signed transaction cell on Notebook P2WPKH on Chapter 2 has the following:

# tx_in with our new sigScript containing the signature we just created
inputs_signed = (
    txid
    + index
    + varint_len(scriptsig)
    + scriptsig
    + sequence
)

Actually as we are signing a segwit transaction the scriptsig is left empty.
@MPins MPins changed the title Fixing a comment for the Notebook P2WPKH on Chapter 2 Fixing the scriptsig for the Notebook P2WPKH on Chapter 2 Dec 26, 2024
@MPins MPins mentioned this issue Dec 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MPins