Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TobinTransfer will charge tobin tax even when transferring to self #1935

Closed
diwu1989 opened this issue Jul 30, 2022 · 1 comment
Closed

TobinTransfer will charge tobin tax even when transferring to self #1935

diwu1989 opened this issue Jul 30, 2022 · 1 comment
Assignees

Comments

@diwu1989
Copy link
Contributor

TobinTransfer signature
func TobinTransfer(evm *vm.EVM, sender, recipient common.Address, amount *big.Int) {
I think if sender == recipient, then the tax shouldn't be charged.

I know tobin is off right now and hasn't ever been turned on, so it's possible to fix this on mainnet without hardfork.

@carterqw2 carterqw2 added triage Issue needs triaging and removed blockchain labels Feb 9, 2023
@carterqw2 carterqw2 removed the triage Issue needs triaging label Feb 16, 2023
@palango
Copy link
Contributor

palango commented Apr 26, 2023

@diwu1989 Thanks for reporting this.

I know tobin is off right now and hasn't ever been turned on, so it's possible to fix this on mainnet without hardfork.

Sadly this is not true for the testnets.

However, the CIP to remove the tobin tax has been accepted and it will be removed in this PR: #2029.

@palango palango closed this as completed Apr 26, 2023
@palango palango self-assigned this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants