Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): Remove da API Interface from Celestia Node #3932

Open
walldiss opened this issue Nov 12, 2024 · 3 comments
Open

refactor(api): Remove da API Interface from Celestia Node #3932

walldiss opened this issue Nov 12, 2024 · 3 comments
Labels
area:api Related to celestia-node API enhancement New feature or request

Comments

@walldiss
Copy link
Member

Implementation ideas

Remove da Interface from Celestia Node


What's the Issue?

Right now, our Celestia node includes a da (Data Availability) interface from the Rollkit client. It was originally added to fix some dependency issues, but it's not actually part of Celestia’s official API.

Why Remove It?

  • Extra Work: We're maintaining something that doesn't need to be here.
  • Confusion: Users might think da is a core part of the Celestia API, which it isn’t.
  • Inconsistency: Other nodes don’t have this interface, leading to mixed expectations.

Proposed Solution:

  1. Move the da Interface:
    • Option A: Create a separate repository for the da interface.
    • Option B: Integrate it directly into the Rollkit repository.
  2. Clean Up Celestia Node:
    • Remove all da related code and dependencies.
    • Update the documentation to point users to the new location for da.

Benefits:

  • Less Maintenance: We can focus on the core features of the Celestia node.
  • Clearer API: Users will have a better understanding of what’s officially supported.
@walldiss walldiss added enhancement New feature or request area:api Related to celestia-node API labels Nov 12, 2024
@gupadhyaya
Copy link

  • are you suggesting we go back to celestia-da? https://github.com/rollkit/celestia-da
  • the original issue with celestia-da was that, we had to run celestia-node and this wrapper celestia-da both to eliminate rollkit directly consuming the celestia blob api and having to import it.
  • why is it a huge burden to maintain this standalone piece? our original intuition of creating the da interface was that, all da solutions will implement the da interface so that rollkit can communicate directly and doesn't have to know about the da implementation behind the scene.

@Wondertan
Copy link
Member

So do you say you had to run 3 binaries including Rollkit and having it in node somehow made it 2?

@gupadhyaya
Copy link

So do you say you had to run 3 binaries including Rollkit and having it in node somehow made it 2?

yes. this is a major ux improvement for rollups (using rollkit), as 2 binaries is unavoidable (one for rollup and other for da) and bare minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants