Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modp2p: increase the SeenMessage interval in PubSub #2934

Open
Wondertan opened this issue Nov 17, 2023 · 1 comment · May be fixed by #2968
Open

modp2p: increase the SeenMessage interval in PubSub #2934

Wondertan opened this issue Nov 17, 2023 · 1 comment · May be fixed by #2968
Labels

Comments

@Wondertan
Copy link
Member

Wondertan commented Nov 17, 2023

We periodically receive old headers from the network that were already synced. Increasing the seen message interval should decrease those.

The only downside is that it may eat slightly more RAM, but it will improve GossipSub peering behaviors. Instead of punishing outdated messages as invalid, it will only reduce communication with the peer. This is especially important when the new CHOKE msg is introduced in the GossipSub v1.2

@Wondertan
Copy link
Member Author

I looked it up, and its 2min by default, which means either:

  • we end up receiving headers with 2mins delay
  • we have several valid headers per height with different hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants