Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modshare/cmd: use height as an argument intead of full ExtendedHeader #2848

Closed
Wondertan opened this issue Oct 13, 2023 · 3 comments · Fixed by #2872
Closed

modshare/cmd: use height as an argument intead of full ExtendedHeader #2848

Wondertan opened this issue Oct 13, 2023 · 3 comments · Fixed by #2872
Assignees
@bao1029p
Labels
good first issue Good for newcomers

Comments

@Wondertan
Copy link
Member

Currently to work with share cmds something like the command below is required.

celestia share get-eds “$(celestia header get-by-height 500 --node.store ~/.celestia-light-mocha-4 | jq .result)” --node.store ~/.celestia-light-mocha-4

Instead, we should be just passing either the hash or height of the header as an argument. The cmd will then internally do 2 rpc calls
@Wondertan Wondertan added the good first issue Good for newcomers label Oct 13, 2023
@bao1029p
Copy link
Contributor

hi @Wondertan, is this issue still open for work ? thank you

@Wondertan
Copy link
Member Author

It is! Feel free to take it over @bao1029p

@bao1029p
Copy link
Contributor

thank you

@bao1029p bao1029p mentioned this issue Oct 24, 2023
Merged
Wondertan pushed a commit that referenced this issue Oct 30, 2023
@bao1029p
refactor(nodebuilder/share/cmd)!: Take block height instead of `Exten…
2066478 
…dedHeader` as argument for share cmds (#2872)

Co-authored-by: Bao <bao@MacBook-Pro.local>
Co-authored-by: heh im a handsome boi <hehimahandsomeboi@Sons-MacBook-Pro.local>

Replace extended headers with block height as an argument in shares cmd

**Issues close**

Close [#2848 ](#2848)

**Changes made**
- Replace all uses of `extended header` as an argument with block height in `nodebuilder/share/cmd/share.go.`
- Add logic to fetch header first with `block height` for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bao1029p bao1029p

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@Wondertan @bao1029p