Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better caching for directory sources #102

Closed
vmrob opened this issue Aug 4, 2016 · 3 comments
Closed

Add better caching for directory sources #102

vmrob opened this issue Aug 4, 2016 · 3 comments

Comments

@vmrob
Copy link
Contributor

vmrob commented Aug 4, 2016

Currently, directory sources can't properly be cached due to build-affecting changes outside the needs configuration.

@ccbrown
Copy link
Owner

ccbrown commented Aug 4, 2016

I've been considering making directory sources do a copy instead of making a symlink. That fixes this and a few other things. It'll make builds a little slower and take more disk space, but I think it's the right thing to do.

@vmrob
Copy link
Contributor Author

vmrob commented Aug 4, 2016

It would be pretty trivial to maintain a copy using rsync. The only real problem is determining a portable way to determine how to make those contents cacheable. I might suggest something like storing a manifest of individual file hashes. By using the --itemize-changes flag for rsync, it appears it would be pretty easy to rehash updated files.

Essentially, the configuration hash for a directory source would be a hash of the configuration + a hash of all of the file contents in the directory.

@ccbrown
Copy link
Owner

ccbrown commented Aug 12, 2016

Merged into #108

@ccbrown ccbrown closed this as completed Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants