Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a consistent way to define "model" field #16

Open
alessandratrapani opened this issue Apr 5, 2024 · 1 comment
Open

Find a consistent way to define "model" field #16

alessandratrapani opened this issue Apr 5, 2024 · 1 comment

Comments

@alessandratrapani
Copy link

For the photodetectors is called: model_number
For the fibers it is called: fiber_model_number
I would keep just model as for the OpticalFilter and the DichroicMirror.
What do you think?
@weiglszonja
Copy link

I agree to keep it consistent, looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weiglszonja @alessandratrapani