From cc088211dce416df05d4f1dea29ad6cc38f261e4 Mon Sep 17 00:00:00 2001 From: Lasse Blaauwbroek Date: Fri, 13 Oct 2023 12:06:56 +0200 Subject: [PATCH] Delete and update some Python 3.7-specific todo notes When I wrote some of these, I was wrong about the affected versions. Upgraded them to v3.9 --- capnp/lib/capnp.pyx | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/capnp/lib/capnp.pyx b/capnp/lib/capnp.pyx index d1a35cb..a708846 100644 --- a/capnp/lib/capnp.pyx +++ b/capnp/lib/capnp.pyx @@ -2062,7 +2062,7 @@ cdef class _DynamicCapabilityClient: cdef public object _parent, _cached_schema def __dealloc__(self): - # Needed to make Python 3.7 happy, which seems to have trouble deallocating stack objects + # Needed to make Python <=3.9 happy, which seems to have trouble deallocating stack objects # appropriately self.thisptr = C_DynamicCapability.Client() @@ -2233,7 +2233,7 @@ cdef class TwoPartyClient: cdef cbool closed def __dealloc__(self): - # Needed to make Python 3.7 happy, which seems to have trouble deallocating stack objects + # Needed to make Python <=3.9 happy, which seems to have trouble deallocating stack objects # appropriately self.thisptr = Own[RpcSystem]() @@ -2280,7 +2280,7 @@ cdef class TwoPartyServer: cdef cbool closed def __dealloc__(self): - # Needed to make Python 3.7 happy, which seems to have trouble deallocating stack objects + # Needed to make Python <=3.9 happy, which seems to have trouble deallocating stack objects # appropriately self.thisptr = Own[RpcSystem]() @@ -2341,7 +2341,7 @@ cdef class _AsyncIoStream: protocol.transport.close() def __dealloc__(self): - # Needed to make Python 3.7 happy, which seems to have trouble deallocating stack objects + # Needed to make Python <=3.9 happy, which seems to have trouble deallocating stack objects # appropriately self.thisptr = Own[AsyncIoStream]() @@ -2424,9 +2424,7 @@ cdef class DummyBaseClass: pass cdef class _PyAsyncIoStreamProtocol(DummyBaseClass, asyncio.BufferedProtocol): - # TODO: Temporary. Needed due to a missing __slots__ definitions in BufferedProtocol on Python 3.7. - # See https://github.com/python/cpython/issues/79575. Can be removed once Python 3.7 is unsupported. - cdef dict __dict__ + cdef object _task cdef public object transport cdef object connected_callback