Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky integration tests #30

Open
pedesen opened this issue Oct 25, 2019 · 3 comments
Open

Fix flaky integration tests #30

pedesen opened this issue Oct 25, 2019 · 3 comments

Comments

@pedesen
Copy link
Collaborator

pedesen commented Oct 25, 2019 •
edited
Loading

Problem

One of two integration tests fails from time to time, due to the 25 seconds jest timeout. Presumably one test is completing tasks of the other tests, if they're executed in parallel.

Proposal

Either make sure to use a different task type or run them sequentially.
@pedesen
Copy link
Collaborator Author

pedesen commented Oct 25, 2019

This should be fixed now with d5d8b51

@pedesen pedesen closed this as completed Oct 25, 2019
@pedesen
Copy link
Collaborator Author

pedesen commented Oct 25, 2019

still experiencing timeouts. Will investigate later.

@pedesen pedesen reopened this Oct 25, 2019
@pedesen
Copy link
Collaborator Author

pedesen commented Nov 14, 2019

The integration might benefit from implementing CreateWorkflowInstanceWithResult (#35), because the amount of setTimeouts could be reduced this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pedesen