-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate endpoints into different APIs #125
Comments
Thanks Noel for opening back this discussion. We totally support this approach based on this rationale:
Based on this, Telefonica proposes to follow the same strategy as other APIs (like location, SIM Swap...), separating features and use cases in separated atomic APIs:
|
This is opening up the discussion from last summer ##55. Is there anything that has changed since then? At that time there was a summary written in #https://github.com/camaraproject/DeviceStatus/blob/main/documentation/SupportingDocuments/decision-support-1-or-2-apis.md |
Hello @JoachimDahlgren - since we discussed months ago we coded/implemented this APIs and this effort changed our perspective on this. We shared the rationales listed by Jorge. I believe that the "All or Nothing" approach for an API implementation is a key to adoption and partial implementation is not manageable for our consumer. |
@bigludo7 @jgarciahospital from dt side we also supporting the approach with 4 APIs and will commit to this. We need to check if it makes sense to have the API-Name in the event or coming here more from the functional side. |
I believe this is a common issue across all APIs, with each API handling these issues differently. To address this, I've initiated a discussion focusing on commonalities to establish a design pattern for addressing these issues, which can then be referenced by other APIs. |
Any update on this one? I saw support from DT (@NoelWirzius ), Telefonica (@jgarciahospital ) & Orange. As we have preparing the September release better to tackle this point soon. |
We could do the split after v0.6.0. But we should first agree on the API names, do we want to have them so long, like this?
|
I support the idea of having four separate YAML files to address separation of concerns. However, without clear API design rules for our Camara project, different teams might opt for different approaches (such as separate endpoints versus separate YAML files)when dealing with the same design problem. |
@akoshunyadi looking of what we add for Device Location project (here) we can probably remove
The interesting point raised by @shilpa-padgaonkar here make me like simple api name :) |
LGTM |
@akoshunyadi @bigludo7 @jgarciahospital @NoelWirzius I am bit concerned that the names connectivity and connectivity-insights (API in https://github.com/camaraproject/ConnectivityInsights/ ) seem almost similar. How do we differentiate the 2? |
Reachability sounds good:
|
We could introduce product categories in Camara, like device, home, network, etc... the same for location so we only have to have a unique feature name within the category |
Good point @shilpa-padgaonkar @akoshunyadi as it will impact other API isn't a topic for commonalities? |
I think we should use now the chance with the new names to enhance the structure/organization of our APIs. |
From TEF we are hoping to be able to bring this change into v0.6.0 since we all already agreed to apply it. |
@fernandopradocabrillo yes, the splitting issue will be a part of 0.6.0. With the alpha1 we'd just like to bring some more quality into 0.6.0, so that we receive some developer feedback to all those other changes. |
@akoshunyadi shell the version be:
? |
Following discussion with @fernandopradocabrillo on the PR #152, here a proposal for the API naming: API to retrieve 'on the fly' reachability status. Name: Looking for team feedback to close this work. |
@maxl2287 it should be wip for now, and the release-preparation PR will set the correct ones |
Fine for me, but now all 4 APIs proposed start with "device- ". We can take those one too, with device as a context. Or are they too long? |
@akoshunyadi I removed On this topic we probably need to review @hdamker proposal here |
In this issue the topic of separating the different endpoints into separate APIs should be covered.
The split makes sense to be aligned with the other Camara Subprojects like "Device Location". On the other hand this will also helps the productization of the APIs and a clear offering from the telco industries.
Suggestion:
The text was updated successfully, but these errors were encountered: