Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action to be JS-based #287

Open
5 tasks
MelSumner opened this issue Oct 28, 2024 · 3 comments
Open
5 tasks

Update action to be JS-based #287

MelSumner opened this issue Oct 28, 2024 · 3 comments

Comments

@MelSumner
Copy link
Collaborator

MelSumner commented Oct 28, 2024

Summary

Update action to be JS based, so Docker is no longer needed.

Action Items

  • refactor Dockerfile into JS
  • update docs that reference Docker (README, CONTRIBUTING)
  • update action.yml
  • update github workflow build.yml
  • deprecate Docker (Remove docker repo & images)
@benschwarz
Copy link
Member

As a prerequisite, we'll need to remove mozjpeg, then we can action this change.

We might need to double check all the action inputs are handled correctly in the transition from Docker to plain ol' JS, but… I think it'll be ok.

@MelSumner
Copy link
Collaborator Author

MelSumner commented Nov 7, 2024

@benschwarz I tried to handle that prereq with some PRs- #285 and #288

I thought once we had something that at least built correctly, we could then work to refactor and update. WDYT?

@benschwarz
Copy link
Member

@MelSumner absolutely! If that works for you, let's go that way 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants