Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tk_tbl.zoo() needs to check input before passing to readr::type_convert() to avoid annoying warning messages #89

Closed
jarodmeng opened this issue Aug 21, 2021 · 4 comments · Fixed by #90

Comments

@jarodmeng
Copy link
Contributor

The issue surfaced in business-science/tidyquant#202 but has its root here in timetk, especially in timetk::tk_tbl.zoo(). readr::type_convert() was changed after tidyverse/readr#1020 which makes it give warning when the input doesn't have any character columns.

It should be a simple fix to check the input passed to readr::type_convert(). I will submit a PR to fix it.

@pverspeelt
Copy link

@mdancho84,

Is this issue going to be picked up and closed in the PR that @jarodmeng created? The warnings are annoying and some people see them as errors.

@mdancho84
Copy link
Contributor

Sorry I must have missed this. Just merged.

@pverspeelt
Copy link

When this is passed on to cran, you should be able to close issue 202 from tidyquant. (and maybe some related ones as well)

@mdancho84
Copy link
Contributor

Ok great. I have a few things I want to check because there are a few other spots I believe typeconvert shows up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants