Questions about adding devices workflow

[michalk-k]

I updated Powercalc to v1.17.0 beta4.
I uploaded newly created profiles to config/powercalc/profiles location to test new shelly profiles (this path didn't exist before)

1. A restart of Powercalc was needed to see those new profiles - I think you said it picks them up on each UI open. Is it expected?
2. I have experienced no discovery of devices existing in my system. I had to add selfconsumption manually. Adding them from library works.
3. When adding a new device from the library, I would expect Powercalc to provide a limited list of manufacturers and models for my comfort. It's not. It lists all manufacturers (or at least a lot of them) and then all the devices that match the device type to the sensor type. Is this correct?
4. Device selector lists names as well as aliases. It looks messy. Is it expected by design? I assume that the reason is that we don't distinguish between the device model and device model id. All of them are represented by name/aliases.

with regards

[bramstroker]

I updated Powercalc to v1.17.0 beta4. I uploaded newly created profiles to config/powercalc/profiles location to test new shelly profiles (this path didn't exist before)

1. A restart of Powercalc was needed to see those new profiles - I think you said it picks them up on each UI open. Is it expected?

Yes, I was mistaken. All profiles are initialized on startup and loaded in memory to prevent constant unneccesary file I/O
New action I introduced lately should also work to refresh the local custom profiles though: https://docs.powercalc.nl/library/library/#updating-the-library.

2. I have experienced no discovery of devices existing in my system. I had to add selfconsumption manually. Adding them from library works.

Auto discovery should just work also for custom profiles.
Please share information about which device you expect to be discovered and the model.json contents. probably a typo somewhere.
Also check: https://docs.powercalc.nl/library/library/#discovery
And enable debug logging which should provide insights in the discovery

3. When adding a new device from the library, I would expect Powercalc to provide a limited list of manufacturers and models for my comfort. It's not. It lists all manufacturers (or at least a lot of them) and then all the devices that match the device type to the sensor type. Is this correct?

The manufacturer and model list should be limited to only profiles which match possible device types for your selected entity.
Which entity (domain) did you choose and which manufacturers/models did you not expect?

4. Device selector lists names as well as aliases. It looks messy. Is it expected by design? I assume that the reason is that we don't distinguish between the device model and device model id. All of them are represented by name/aliases.

I have found PR where the local loader was overhauled and this was implemented:
#2625
There was some discussion exactly about this issue. I disagreed to put the aliases in this listing specifically because it becomes messy and is inconsistent with the remote loader (built-in library). But seems I missed something where still the aliases are also listed in the listing.
Anyway no really big deal as most users will not use aliases for local models. When you submit the profiles to powercalc built-in library the aliases will not be shown.

[bramstroker]

I have made some additional improvements in discovery flow and also made the logging better and more consistent.

Have been released in v1.17.0-beta.7

[michalk-k]

Just noticed that. Downloading...
I didn't find any entry of plugs_1_switch in core.config_entries :(. I downgraded to beta3, then the plug was offered with discovery. But as far as I remember, in those older releases, there was a bug offering discovered device multiple times. So I'm keeping diggin'

[bramstroker]

Let me know if still not discovered with this new beta. Then we can add some extra debug logging as to what exactly prevents discovery.

[michalk-k]

yeah... I need assistance.
The PluS has been discovered and successfully added. It's discovered by an entity.
I have another case, with Shelly 3EM (discovered by a device)

PC Debug entry:

2025-01-05 10:58:00.770 DEBUG (MainThread) [custom_components.powercalc.discovery] 62684ca9dd76203552c19bc16c1572a6: Found model information on device (manufacturer=Shelly, model=Shelly 3EM, model_id=SHEM-3)
2025-01-05 10:58:00.770 DEBUG (MainThread) [custom_components.powercalc.discovery] 62684ca9dd76203552c19bc16c1572a6: Already setup with discovery, skipping

Registry entry:

      {"area_id":"e0a51b5d0e8241c688d43627b08b013d","config_entries":["60ce6d798552456d8abb9f4d5b9bb9f8"],"configuration_url":"http://192.168.107.76","connections":[["mac","XXXXXXXXXXXX"]],"created_at":"2024-12-27T13:46:25.818651+00:00","disabled_by":null,"entry_type":null,"hw_version":null,"id":"62684ca9dd76203552c19bc16c1572a6","identifiers":[],"labels":[],"manufacturer":"Shelly","model":"Shelly 3EM","model_id":"SHEM-3","modified_at":"2025-01-04T23:40:03.077420+00:00","name_by_user":null,"name":"Shelly 3EM Cube","primary_config_entry":"60ce6d798552456d8abb9f4d5b9bb9f8","serial_number":null,"sw_version":null,"via_device_id":null},

Profile (modified to match latest features)

{
  "measure_description": "Manually measured. Transcribed from https://www.youtube.com/watch?v=RlSCe9xaUPE",
  "measure_method": "manual",
  "measure_device": "GW Instek GPM-8310",
  "name": "Shelly 3EM",
  "aliases": [
    "SHEM-3"
  ],
  "standby_power": 1.22,
  "device_type": "power_meter",
  "calculation_strategy": "fixed",
  "discovery_by": "device",
  "sensor_config": {
    "power_sensor_naming": "{} Device Power",
    "energy_sensor_naming": "{} Device Energy"
  },
  "created_at": "2024-12-01T16:51:00",
  "author": "RubenKelevra <cyrond@gmail.com>"
}

[bramstroker]

Are you on discord? If so, you can sent me PM (bramski3414). Then I can sent you modified version of discovery.py with more debug logs.