code quality/check

[Mariusthvdb]

when editing the https://github.com/bramstroker/homeassistant-powercalc/blob/master/custom_components/powercalc/aliases.py file I couldn't help but notice the non alphabetical order of it.
Having PR my small share in core Home Assistant code, this surprised be tbh, as that has very strict checks for that.

Wouldn't it be a sound suggestion to adopt that in Powercalc too (Black/Lint etc etc), and use it like below (not completely sure, didn't actually blackify it yet...)

"""Aliases for manufacturers and model IDs."""

from __future__ import annotations

MANUFACTURER_ALIASES = {
    "ADEO": MANUFACTURER_LEXMAN,
    "Fibaro": MANUFACTURER_FIBARO,
    "Greenwave": MANUFACTURER_GREENWAVE,
    "IKEA": MANUFACTURER_IKEA,
    "LightZone": MANUFACTURER_MELITECH,
    "LUMI": MANUFACTURER_AQARA,
    "MLI": MANUFACTURER_MULLER_LIGHT,
    "Philips": MANUFACTURER_SIGNIFY,
    "Xiaomi": MANUFACTURER_AQARA,
}

MANUFACTURER_DIRECTORY_MAPPING = {
    MANUFACTURER_AQARA: "aqara",
    MANUFACTURER_IKEA: "ikea",
    MANUFACTURER_FEIBIT: "jiawen",
    MANUFACTURER_FIBARO: "fibaro",
    MANUFACTURER_GREENWAVE: "greenwave",
    MANUFACTURER_LEDVANCE: "ledvance",
    MANUFACTURER_LEXMAN: "lexman",
    MANUFACTURER_MELITECH: "melitec",
    MANUFACTURER_MULLER_LIGHT: "mueller-licht",
    MANUFACTURER_OSRAM: "osram",
    MANUFACTURER_SIGNIFY: "signify",
    MANUFACTURER_TUYA: "tuya",
    MANUFACTURER_WIZ: "wiz",
    MANUFACTURER_YEELIGHT: "yeelight",
}

MANUFACTURER_AQARA = "Aqara"
MANUFACTURER_FEIBIT = "Feibit Inc co.  "
MANUFACTURER_FIBARO = "Fibargroup"
MANUFACTURER_GREENWAVE = "GreenWave Reality Inc."
MANUFACTURER_IKEA = "IKEA of Sweden"
MANUFACTURER_LEDVANCE = "LEDVANCE"
MANUFACTURER_LEXMAN = "Lexman"
MANUFACTURER_MELITECH = "MeLiTec"
MANUFACTURER_MULLER_LIGHT = "Müller Licht"
MANUFACTURER_OSRAM = "OSRAM"
MANUFACTURER_SIGNIFY = "Signify Netherlands B.V."
MANUFACTURER_TUYA = "TuYa"
MANUFACTURER_WIZ = "WiZ"
MANUFACTURER_YEELIGHT = "Yeelight"

Black online code formatter seems indicate it being ok

[bramstroker]

Code is automatically formatted with black and also isort is run. See here https://github.com/bramstroker/homeassistant-powercalc/blob/master/.github/workflows/format-code.yml#L34.
So all code in powercalc should adhere to black.

I don't think black or any linting tool (like flake8) enforces constants to be on alphabetical order and also not dictionary keys, but I need to research that.

I definitely agree that this must be alphabetically ordered.

[bramstroker]

flake8 also don't enforces this. I just ran it and it succeeded on the aliases.py file without errors or wanings.

Btw in HA core constant and enums are also not orders correctly always, so I don't think they do (or can) enforce it. I see a lot of cases in the first file I check.
https://github.com/home-assistant/core/blob/dev/homeassistant/const.py#L316