You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was upgrading from 2.0.5 and wondered several hours of debugging why it didn't work anymore.
Narrowed it down to the 4.x to 5.x change.
IntelliJ only let me import framebus via import {Framebus} from 'framebus/dist/framebus';
So, I was obviously missing the mandatory attach() call done in index.ts.
I want therefore to request a note in README.md to either add an additional line import 'framebus/dist/index'; or alternativly call attach() in dist/lib/attach directly.
This might prevent some frustration other users might have.
Thank you.
Sidenote - I found some typos in the README: conjuction, succesfully, refrence
The text was updated successfully, but these errors were encountered:
rala72
changed the title
Add mandatory "attach" call to README (for typescript)
Add note for mandatory "attach" call to README (for typescript)
Mar 28, 2024
@rala72 thanks for pointing these things out to us. We've made a ticket in our backlog to cleanup the README with your suggestions. For internal tracking -> 118
If you'd like, you can also open a PR with these changes for us to review.
We'l leave this issue open until we're able to make these updates.
General information
Issue description
I was upgrading from 2.0.5 and wondered several hours of debugging why it didn't work anymore.
Narrowed it down to the 4.x to 5.x change.
IntelliJ only let me import framebus via
import {Framebus} from 'framebus/dist/framebus';
So, I was obviously missing the mandatory
attach()
call done inindex.ts
.I want therefore to request a note in README.md to either add an additional line
import 'framebus/dist/index';
or alternativly callattach()
indist/lib/attach
directly.This might prevent some frustration other users might have.
Thank you.
Sidenote - I found some typos in the README:
conjuction
,succesfully
,refrence
The text was updated successfully, but these errors were encountered: