Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated CSP configuration #912

Open
DoroGi opened this issue Nov 20, 2023 · 4 comments
Open

updated CSP configuration #912

DoroGi opened this issue Nov 20, 2023 · 4 comments
Labels

Comments

@DoroGi
Copy link

DoroGi commented Nov 20, 2023

General information

  • SDK/Library version: 1.40.2
  • Environment: Sandbox and Production
  • Browser and OS: All

Issue description

I find the CSP documentation to be incomplete.

I implemented the CSP as shown here: https://braintree.github.io/braintree-web-drop-in/docs/current/index.html#content-security-policy, but I started receiving reports of a few urls (i.e. www.paypalobjects.com and https://google.com/pay) not being allowed.
Then I found that braintree-web has a different suggested configuration here: https://braintree.github.io/braintree-web/current/,
that seems to be more updated that the drop-in one.
Using those configurations for Google Pay, and Paypal I fixed the issue. Should the drop-in doc be updated? Or maybe merged to the braintree-web one?

Also, I still receive some csp reports regarding a specific aws URL ([omitted].us-east-1.amazonaws.com/prod/log) being called by a cardinalcommerce script. It this intended? Do I have to add a CSP conf for it?

@jplukarski
Copy link
Contributor

Hey @DoroGi , thanks for reporting this to us. We'll add a card in our backlog to get our Drop-In reference documentation up to date ASAP. We'll also reach out to CardinalCommerce about that AWS URL you saw to verify if we should also update our 3DSecure-specific directives.

For internal tracking -> 28714

@DoroGi
Copy link
Author

DoroGi commented Nov 21, 2023

Thank you very much!

@DoroGi
Copy link
Author

DoroGi commented Dec 11, 2023

Hi, thank you for the update on google pay!
Do you have any news on the aws URL?

Also, I just noticed that there are a number of calls directed to "spay.samsung.com".
Braintree documentation talks about samsung pay, but it does not seem to be mentioned on the web dropin documentation.
How come that I see calls being performed to samsung pay? Is it a bug?

@karolyi
Copy link

karolyi commented Aug 18, 2024

+1.

not only the amazonaws url is extra, there is missing configuration from the documentation for form-action, for example.

Paypal also needs the *.paypalobjects.com in img-src.

Seeing that my other issue (#939) is ignored as well, I don't see a fast resolution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants