Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call_user_func_array calls need more array_values updates #171

Open
sc0ttkclark opened this issue Sep 7, 2023 · 1 comment
Open

call_user_func_array calls need more array_values updates #171

sc0ttkclark opened this issue Sep 7, 2023 · 1 comment
Assignees
Milestone

Comments

@sc0ttkclark
Copy link

There are still some stragglers that use call_user_func_array and pass in arrays that have string keys. Those get interpreted as PHP named arguments just like what was reported at #147

That one case was fixed but there are likely others, especially ones in this kind of context with min/max or width/height.

This may take manual review on your side to ensure that they are caught as I don't want to just PR the changes with array_values() everywhere it may not be needed.

@bordoni
Copy link
Owner

bordoni commented Sep 8, 2023

Thank you @sc0ttkclark I finally should have some extra time this upcoming week, I will definitely make sure this is included.

@bordoni bordoni self-assigned this Sep 8, 2023
@bordoni bordoni added this to the Version: 0.6.2 milestone Sep 8, 2023
@bordoni bordoni modified the milestones: Version: 0.6.2, 0.6.4 Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants