Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate Dockerfile for integration_tests #807

Open
wsdt opened this issue May 11, 2023 · 1 comment
Open

Create separate Dockerfile for integration_tests #807

wsdt opened this issue May 11, 2023 · 1 comment

Comments

@wsdt
Copy link
Contributor

wsdt commented May 11, 2023

Issue Type

[ ] bug report
[ x] feature request

Current Behavior

Currently the integration_tests just use the packages-Dockerfile which means that the integration_tests are built into the image itself. This may be okay for the CI/CD pipeline, but a really bad experience when debugging integration tests locally - especially since the Dockerfile is not really optimized for caching its build output (thus even just a minimal change in the integration test requires a docker rebuild of several minutes (up to 5 minutes).

Expected Behavior

Integration tests should be in a volume, meaning that if there are changes the docker image can dynamically react to it. Or the container at least only needs to be restarted to take changes into account.

Suggested Fix

Create Dockerfile dedicated to locally debugging integration tests with volume.

@InoMurko
Copy link
Contributor

I just do this:

yarn && yarn build
export L1_URL=http://localhost:9545/
export L2_URL=http://localhost:8545/
export URL=http://localhost:8080/addresses.json
export BASE_URL=http://localhost:8080/addresses.json
export BOBA_URL=http://localhost:8080/boba-addr.json
export AA_BOBA_URL=http://localhost:8080/aa-addr.json
export BUNDLER_URL=http://localhost:3000/rpc
export ENABLE_GAS_REPORT=1
export NO_NETWORK=1
export RETRIES=200
export L2_CHAINID=31338 #unfortunately, elsewhere the L2_CHAINID is called CHAIN_ID
export PRIVATE_KEY='0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80'
export PRIVATE_KEY_2='0xc526ee95bf44d8fc405a158bb884d9d1238d99f0612e9f33d006bb0789009aaa'
export PRIVATE_KEY_3='0x8166f546bab6da521a8369cab06c5d2b9e46670292d85c875ee9ec20e84ffb61'
export BOBALINK_PRIVATE_KEY='0x92db14e403b83dfe3df233f83dfa3a0d7096f21ca9b0d6d6b8d88b2b4ec1564e'
cd integration-tests
npx hardhat test --network boba --no-compile --config ./hardhat.config.ts test/eth-l2/boba_aa_fee_boba.spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants