Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show moonphase icon after sunset #12

Open
ehula opened this issue Aug 17, 2023 · 3 comments
Open

show moonphase icon after sunset #12

ehula opened this issue Aug 17, 2023 · 3 comments

Comments

@ehula
Copy link

ehula commented Aug 17, 2023

This is a great project. I have crafted something very similar to this myself, without the tooltips.

One thing I did was to change the indicator icon from the current condition icon to the moonphase icon after sunset since it made more sense to me, and provided more information/eye candy. Then, after sunrise, restore the indicator icon to be the current condition.

Would you consider adding this feature?

@bjesus
Copy link
Owner

bjesus commented Sep 2, 2023

That's a pretty cool idea. I'm quite busy at the moment with other stuff, but if you submit a PR I'll happily merge it

@hertz0022
Copy link

hertz0022 commented Dec 15, 2023

I was setting up the module and thought the same thing. That's a nice info to have!
Or at least is there an easy way to add the moonphase in the tooltip?
Unfortunately I don't know to code in Python for now in order to change the script. :(
A really nice waybar module anyway!! Appreciated!

@FMGordillo
Copy link

@ehula

  1. how do you think this feature should be activated? I mean, the parameter's name
  2. I don't think should be linked to be shown only at sunset, maybe always to be shown at the tooltip, but you choose to show it at the text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants