We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BaseActor._task should call set_exception on the Future of QueryMessage when message handler raises. It can look like this:
BaseActor._task
set_exception
Future
QueryMessage
@asyncio.coroutine def _task(self): message = yield from self._inbox.get() try: handler = self._handlers[type(message)] is_query = isinstance(message, QueryMessage) try: response = yield from handler(message) except Exception as ex: if is_query: message.result.set_exception(ex) else: if is_query: message.result.set_result(response) except KeyError as ex: raise HandlerNotFoundError(type(message)) from ex
What I'm not sure about is whether plain message handler's exception should be re-risen, eaten or maybe a warning should be emitted.
The text was updated successfully, but these errors were encountered:
fix: Propagate exceptions from a message handler biesnecker#3
b406fed
Merge pull request #5 from saaj/master
7c899fa
Fixes for #3 and #4
No branches or pull requests
BaseActor._task
should callset_exception
on theFuture
ofQueryMessage
when message handler raises. It can look like this:What I'm not sure about is whether plain message handler's exception should be re-risen, eaten or maybe a warning should be emitted.
The text was updated successfully, but these errors were encountered: