Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of useless stuff #1

Open
bestouff opened this issue Nov 8, 2017 · 6 comments
Open

Get rid of useless stuff #1

bestouff opened this issue Nov 8, 2017 · 6 comments

Comments

@bestouff
Copy link
Owner

bestouff commented Nov 8, 2017

Bindgen generated too much bindings (e.g. __pthread_mutex_s), what's the easy way to generate only "interesting" bindings ?

@koutheir
Copy link

Use allow lists.

@bestouff
Copy link
Owner Author

Ok thanks

@koutheir
Copy link

Why is this closed? Have you used bindgen allow lists already?

@bestouff
Copy link
Owner Author

This issue dates back from a few years, I have switched jobs since and don't use e2fslib-sys anymore (and to be honest I had forgotten about it).
You're right I'll left it opened and try to fix that someday In My Copious Spare Time ™.

@bestouff bestouff reopened this Dec 29, 2021
@koutheir
Copy link

I understand. It's just that keeping the issue open might suggest to someone else to make a pull request and fix it. Would you still accept pull requests? Or is this project completely done for you?

@bestouff
Copy link
Owner Author

I'd still gladly accept PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants