Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favourite disabling doesn't work #3

Open
beckettkev opened this issue Apr 9, 2016 · 2 comments
Open

Favourite disabling doesn't work #3

beckettkev opened this issue Apr 9, 2016 · 2 comments
Assignees
@jquintozamora
Labels
bug
Milestone
Mango

Comments

@beckettkev
Copy link
Owner

Favourite disabling doesn't work when selected from the settings page.
@beckettkev beckettkev added the bug label Apr 9, 2016
@beckettkev beckettkev modified the milestone: Mango Apr 9, 2016
@jquintozamora
Copy link
Contributor

Hi Kev, when Favourite is disabled, what should happens? Just hide the favorites tab?

@beckettkev
Copy link
Owner Author

Yes. So basically we should feed that into the menu component and the
person one so that:

-the button isn't displayed in the people card
-the favourite menu tab is not displayed
On 25 Apr 2016 1:28 p.m., "Jose Quinto" notifications@github.com wrote:

Hi Kev, when Favourite is disabled, what should happens? Just hide the
favorites tab?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jquintozamora jquintozamora

Labels
bug
Projects
None yet
Milestone
Mango
Development

No branches or pull requests
2 participants
@beckettkev @jquintozamora