-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any chance there will be a support of counters? #16
Comments
Reading that discussion - i would assume that the request is to have counters that live effectively forever (survive restarts, etc.)? This is a non-goal for pinba imo. There are plenty of those on the market anyway. It might be a nice idea to have easy integration with those tools, though. if i got the idea wrong - feel free to elaborate. |
We are trying to implement an exporter from Pinba to a real time series database. Other tools, eg. prometheus, handle counter resets, so surviving restart is not a big deal. Right now we can emulate counters using timers with a tag report so that we have a rolling 2 minute window of "counter-requests-hits". But this window can not be queried for a time interval of data (something like I hoped we can use Pinba as an alternative to Statsd (for internal application metrics), as it does it's job extremely well for collecting PHP metrics. |
Hm, i think i get it now. This is a nice idea, but i'm kinda not sure how to do it interface-wise. Internally the data is stored in 1-second wide 'timeslices' (that are all merged on select) - just need to find a way to expose that info with sql interface. Any ideas ? |
I was thinking of maybe making pinba internal stuff into a library that can be used to build other access interfaces (like a go daemon with it's own query language or whatever). |
Another interpretation, suggested by @Sannis is: This would mean that report never deletes anything. |
That seems a good idea and will provide enough information to integrate Pinba with other monitoring solutions. Not sure how much use it will make for Badoo team though :) I think for now we’ll evaluate another alternative solutions for custom application metrics (seems like https://github.com/prometheus/statsd_exporter looks exactly what we need) and leave Pinba for general metrics and timers. Thank you for your time on researching on this topic! |
Ok, i guess this is a "nice to have" feature from now on. |
tony2001/pinba_engine#3
The text was updated successfully, but these errors were encountered: