Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors may occur when the channel name is in Chinese #20990

Open
fargo315 opened this issue Dec 21, 2024 · 3 comments
Open

Errors may occur when the channel name is in Chinese #20990

fargo315 opened this issue Dec 21, 2024 · 3 comments

Comments

@fargo315
Copy link

fargo315 commented Dec 21, 2024

Current Behaviour

The isdigit function will encounter errors when the channel name is in Chinese
ChannelHandler.cpp -> if (isdigit(channelName[0])) return;

Expected Blizzlike Behaviour

isdigit() -> iswdigit()

Source

No response

Steps to reproduce the problem

The isdigit function will encounter errors when the channel name is in Chinese

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. 25fb6cc+ 2024-12-20 15:38:17 +0100 (master branch) (Win64, Debug, Static)

Microsoft Visual C++ Runtime Library

Debug Assertion Failed!

Program: D:\Build\bin\Debug\worldserver.exe
File: minkernel\crts\ucrt\src\appcrt\convert\isctype.cpp
Line: 36

Expression: c >= -1 && c <= 255

For information on how your program can cause an assertion
failure, see the Visual C++ documentation on asserts.

(Press Retry to debug the application)

Operating system

Windows 10 x64

Custom changes or Modules

No response

@fargo315
Copy link
Author

Addendum, when using the Chinese client to extract DBC, it will appear

@TheSCREWEDSoftware
Copy link
Contributor

Provide the hash of your current AC rev.

@fargo315
Copy link
Author

Provide the hash of your current AC rev.

AzerothCore rev. 25fb6cc+ 2024-12-20 15:38:17 +0100 (master branch) (Win64, Debug, Static)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants