Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup: add tag, favorite, and delete actions to edit modal #42

Open
ayoung19 opened this issue Jan 6, 2025 · 2 comments
Open

popup: add tag, favorite, and delete actions to edit modal #42

ayoung19 opened this issue Jan 6, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@ayoung19
Copy link
Owner

ayoung19 commented Jan 6, 2025

UI Ideas:

Clipboard History Pro
image

Linear
image

@ayoung19 ayoung19 added the enhancement New feature or request label Jan 6, 2025
@pgiouroukis
Copy link

Can I work on this?

I already implemented two prototypes for these features, but I have some design decisions that would be nice to address:

  1. Regarding tags: since there is a "Save" button in the edit modal, should the newly added tags be saved only when the user clicks on "Save"? Or should we keep the same behavior as in the main page, where a tag can be saved directly from the TagSelect component?
  2. Regarding favorite: Similar question as 1. Should the "favorite" state be saved when the user clicks on "Save", or simply when the user clicks on the favorite icon?
  3. Should we reuse the existing components (which currently are buttons) or re-think some new components?

First prototype:
Screenshot 2025-01-09 at 3 58 38 PM

Another idea would be to have the "favorite" and "delete" icons along the "Cancel" and "Save" buttons in the modal, and add the tags as a new item in the grid, something like this:

Second prototype:
Screenshot 2025-01-09 at 4 13 32 PM

@ayoung19
Copy link
Owner Author

ayoung19 commented Jan 9, 2025

Can I work on this?

Of course!

Regarding 1) and 2), favoriting and tagging can just happen without the need to save I think it'll be the easiest to implement and makes enough sense. 3) depends on which layout we pick.

Since design stuff is a lot more open ended and back/forth this might be easier to answer offline. Feel free to join our Discord if you'd like to discuss there! https://discord.gg/5QQXXsApQA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants