diff --git a/crates/sp-domains-fraud-proof/src/tests.rs b/crates/sp-domains-fraud-proof/src/tests.rs index 5bc1db18b4..946d01a2d5 100644 --- a/crates/sp-domains-fraud-proof/src/tests.rs +++ b/crates/sp-domains-fraud-proof/src/tests.rs @@ -12,7 +12,7 @@ use subspace_test_service::MockConsensusNode; use tempfile::TempDir; #[tokio::test(flavor = "multi_thread")] -async fn runtime_instance_storage_assumptions_are_correct() { +async fn storage_change_of_the_same_runtime_instance_should_perserved_cross_runtime_calls() { let directory = TempDir::new().expect("Must be able to create temporary directory"); let mut builder = sc_cli::LoggerBuilder::new(""); diff --git a/domains/client/block-preprocessor/src/lib.rs b/domains/client/block-preprocessor/src/lib.rs index 43618f3394..f5b255dac8 100644 --- a/domains/client/block-preprocessor/src/lib.rs +++ b/domains/client/block-preprocessor/src/lib.rs @@ -310,7 +310,6 @@ where .is_ok(); if !is_legal_tx { - // TODO: Generate a fraud proof for this invalid bundle return Ok(BundleValidity::Invalid(InvalidBundleType::IllegalTx( index as u32, ))); diff --git a/domains/runtime/evm/src/lib.rs b/domains/runtime/evm/src/lib.rs index 779c2384b1..312c722bdb 100644 --- a/domains/runtime/evm/src/lib.rs +++ b/domains/runtime/evm/src/lib.rs @@ -913,10 +913,10 @@ impl_runtime_apis! { return Err(InvalidTransaction::BadMandatory.into()); } - let encoded = uxt.encode(); - let encoded_len = encoded.len(); + let encoded_len = uxt.encoded_size(); - // We invoke `pre_dispatch` in addition to `validate_transaction`(even though the validation is almost same) as that will add the side effect of SignedExtension in the storage buffer + // We invoke `pre_dispatch` in addition to `validate_transaction`(even though the validation is almost same) + // as that will add the side effect of SignedExtension in the storage buffer // which would help to maintain context across multiple transaction validity check against same // runtime instance. match xt.signed { diff --git a/domains/test/runtime/evm/src/lib.rs b/domains/test/runtime/evm/src/lib.rs index e6cab20a52..00b925993b 100644 --- a/domains/test/runtime/evm/src/lib.rs +++ b/domains/test/runtime/evm/src/lib.rs @@ -900,10 +900,10 @@ impl_runtime_apis! { return Err(InvalidTransaction::BadMandatory.into()); } - let encoded = uxt.encode(); - let encoded_len = encoded.len(); + let encoded_len = uxt.encoded_size(); - // We invoke `pre_dispatch` in addition to `validate_transaction`(even though the validation is almost same) as that will add the side effect of SignedExtension in the storage buffer + // We invoke `pre_dispatch` in addition to `validate_transaction`(even though the validation is almost same) + // as that will add the side effect of SignedExtension in the storage buffer // which would help to maintain context across multiple transaction validity check against same // runtime instance. match xt.signed {