-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aurelia with storybook #905
Comments
seems to be in there plain aurelia project. so, just use aurelia-cli do make one for you, same as some other frameworks there |
I've configured storybook webpack.config.js to add aurelia webpack plugin like this plugins: [...config.plugins, new AureliaWebPackPlugin.AureliaPlugin()] But now when building webpack i got this error:
Should I add any additional config info ? Default aurelia webpack config dont have any specific stuff. I think this error is only thing that prevents me to run aurelia app inside storybook. Any ideas ? |
try .AureliaPlugin({includeAll: "src"}) https://github.com/aurelia/webpack-plugin/wiki/AureliaPlugin-options |
Is anyone actively working on this? |
Not on our core team at least. We'd love someone to help out with this, particularly for Aurelia 2. |
Au2 storybook is actively getting worked on. Prototype should be done this week. |
@brandonseydel can you give link to repo ? |
https://github.com/brandonseydel/storybook it is working actually. Just needs some cleanup to make everything nicer. |
I pushed another version which handles global container/registration/component registration. This also allows adhoc registration per story past the original. One could register a plugin in the config.ts and then register custom component in story for HMR. |
@brandonseydel We are really interested in your branch ! Any update :) ? |
I will nudge storybook authors some more. We want it for our alpha release, so it should be rtm soon. |
I think i will actually open a PR into them so the back and forth will become public. I will link it when complete. |
Looking forward to reading these back and fourth! |
@brandonseydel any progress with storybook ? |
|
It is out already on NPM (au2). https://www.npmjs.com/package/@storybook/aurelia |
@brandonseydel Any instructions on how to set this up? |
@elimt I found an example on https://github.com/storybookjs/storybook/tree/master/examples/aurelia-kitchen-sink that I'll try out. But some type of guide on how to set this up would be helpful. The In https://github.com/storybookjs/storybook/blob/next/lib/cli/src/project_types.ts, there is no type for aurelia. Aurelia is only a "supported framework". What type should it be? @brandonseydel |
@jenslw I will try to get a small guide set up and I will investigate the --type not working with SB |
After experimenting a bit with the example aurelia-kitchen-sink, I found out that |
Thank you @brandonseydel |
Yes this is au2 only.
|
@brandonseydel Any updates on Aurelia's storybook. I made few changes and it's opening storybook. unfortunately, It doesn't show up the example button component. |
I am also interested in this. I have managed to get the go ahead to use AU2 at my work against all odds but we need it working with storybook |
@EisenbergEffect anyone have information on this I am trying to get storybook Aurelia2 working but it looks broken to me. issues with typings and something about reflect metadata being imported twice |
A commit that relax the strictness around metadata has been merged. Can you try again @Infuser |
Hi,
Im trying to make aurelia work with storybook. I tried to initialize aurelia with webpack, but when storybook triest to load aurelia app i get this message:
Webpack config file:
Full repo source code to clone is at https://github.com/bemon/storybook if anyone wants to take a look and try run.
I dont know how exacly configure webpack to proper load aurelia modules.
The text was updated successfully, but these errors were encountered: