Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of current param in snippet #77

Open
keevan opened this issue Dec 19, 2021 · 0 comments
Open

Improve display of current param in snippet #77

keevan opened this issue Dec 19, 2021 · 0 comments

Comments

@keevan
Copy link

keevan commented Dec 19, 2021

The default snippet is currently, okay. But it can be so much better, such as by highlighting/bolding the current parameter when the signature helper is activated.

I've attempted to do this locally and pushed my changes to a fork, but it's not the end goal I want.

image

https://github.com/keevan/atom-ide-signature-help/tree/improve-display-of-current-param
https://github.com/atom-community/atom-ide-signature-help/compare/master...keevan:improve-display-of-current-param?expand=1

I want a solution where:

  • the current param is very clearly displayed, and the user knows immediately where it is and what it's used for
  • existing syntax highlighting for the grammar provided in the snippet to work as normal - my current fork breaks this as a way of circumventing the stripping of tags (bold, strong) or lack thereof (I've tried markdown style as well) when passing the snippet prop in ViewContainer

Ideally, changes would be made there to allow for some form of bolding in that atom-ide-base project, and all might be well, but this was easier.


Also as a side thing, I had an issue dev'ing this package for some reason as I would expect. Not sure if you knew what I might be doing wrong.
Steps:

  • Fork this repo
  • Clone this repo somewhere and cd there
  • Run apm install and for good measure npm install && apm link --dev
  • Run atom in --dev mode in target project atom --dev .
  • Expect signature to display changes but I get an empty box.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant