Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Inconsistency in Nearest Source Estimation in dc_mag Calculation #44

Open
MohamadJ283 opened this issue Apr 11, 2024 · 2 comments

Comments

@MohamadJ283
Copy link

Hey,

During our work on anomaly detection(cc: Mr. @ManuGangler), we've identified a discrepancy in the calculation of dc_mag.

Nearest Source Estimation Error:
Upon further investigation, we've observed an inconsistency in the nearest source estimation process across filters (red/green) for the same object. Contrary to expectation, in certain cases, we've found that the nearest source varies between filters. This discrepancy arises from instances where noise detection is erroneously classified as a source in one filter but not in the other.

The issue is in: photometry_tutorial.ipynb (refer to [In [6]] section).

Please check this notebook; we explained in detail the error and suggested a modification.

Best regards,

@JulienPeloton
Copy link
Member

Thanks @MohamadJ283 for reporting! However I cannot access the notebook. Is this in a private repository?

@ManuGangler
Copy link

Repository is now opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants