Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Some points need to improve #23

Open
yjhmelody opened this issue Feb 20, 2021 · 1 comment
Open

Some points need to improve #23

yjhmelody opened this issue Feb 20, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yjhmelody
Copy link
Contributor

  • We need to explore some ways to extract the ask! code from the as compiler internal. At present, it can be completely written as an independent ts project, in my personal opinion.
  • We should define the metadata.json's spec class rather than generate it by template engine. It's hard to maintain and test it.
  • The code in some places is hard-coded, and parameterization and configuration should be considered.
  • Consider to add some prefix for contract decorator, for avoiding name conflicts.
  • Add more unit tests.
@yjhmelody yjhmelody added enhancement New feature or request good first issue Good for newcomers labels Feb 20, 2021
@van-bright
Copy link
Collaborator

nice suggestions!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants