Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CUDA specific code from the AppRun class and move it into machine specific subclasses #355

Open
cms21 opened this issue May 24, 2023 · 0 comments
Open

Remove CUDA specific code from the AppRun class and move it into machine specific subclasses #355

cms21 opened this issue May 24, 2023 · 0 comments

Comments

@cms21
Copy link
Contributor

cms21 commented May 24, 2023

The _set_envs() routine in the AppRun class has CUDA specific code (here:

balsam/balsam/platform/app_run/app_run.py

Line 143 in 9a02ef0

envs["CUDA_DEVICE_ORDER"] = "PCI_BUS_ID"
)

We should remove this and move it to the subclasses for machines that need it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cms21