spring agent - spring gateway4.x

[chenxu1986]

Search before asking

• I had searched in the issues and found no similar issues.

Apache SkyWalking Component

Java Agent (apache/skywalking-java)

What happened

my project use spring boot 3.2， spring-could-starter-gateway version is 4.1.5
I use skywalking agent version is 9.3.0， oapserver version is 9.3.0

I put the option-plugin “apm-spring-cloud-gateway-4.x-plugin-9.3.0.jar” and “apm-spring-webflux-6.x-plugin-9.3.0.jar” into the agent dir。

Then I conducted tests and found the following issues：

In the gateway service, a request is split into two spans, as shown in the following figure. SpringCloudGateway/RoutingFilter and /testsk/api/inner/login/loginPwd are the same request, and you can see that their trace IDs are the same, but they are displayed as two on SK UI. Upon closer inspection, it is found that their segment IDs are different. Normally, they are all on the same gateway instance, and the segmentation ID should be consistent。

The downstream service user, traceid of the gateway is completely different from that of the gateway, and has not received the traceid passed down by the gateway

So, my problem is that there is a problem with the trace passing inside the gateway. I traced the source code of the agent and found that in NettyRoutingFilterInterceptor, the afterMethod was executed before the subsequent call was initiated, causing ContextManager. stopSpan();. After exiting span, FHIR FinalizerSendInterceptor was executed, and ContextManager. isActive() became null, causing the traceid not to be passed down.
I don't know if I debugged it wrong, but I hope the trace information can be processed correctly within the gateway. I hope everyone can help me

What you expected to happen

I hope the trace information can be processed correctly within the gateway. I hope everyone can help me

How to reproduce

Describe the steps in the previous section

Anything else

No response

Are you willing to submit a pull request to fix on your own?

• Yes I am willing to submit a pull request on my own!

Code of Conduct

• I agree to follow this project's Code of Conduct

[wu-sheng]

Segment IDs are different as they are in different threads. This is expected case in the Java agent.

[wu-sheng]

I don't have any spring gateway experience, I have repeated thus many times in many issues.

It is ok you keep this public here, wait for someone could help, but I am not capable to do that.

[wu-sheng]

There are gateway tesr scenario in the code bases. You could find out how it is tested, and whether your cases and versions are covered. Someone reported weeks ago, new gateway may have different behavior, if so, we rely on new patch from someone to fix this.

[chenbihao]

There are gateway tesr scenario in the code bases. You could find out how it is tested, and whether your cases and versions are covered. Someone reported weeks ago, new gateway may have different behavior, if so, we rely on new patch from someone to fix this.

I found a lot of information today

I'm not sure if my understanding is correct, but currently there are known issues:
-The span is fragmented and cannot be aggregated into one link
-The TID log cannot be transmitted and cannot be aggregated into one link

I have an additional question to ask. Where can I find the location of the apm-toolkit-logback repository? I would like to see the source code

[wu-sheng]

They are all in skywalking-java repo.

[huicunjun]

@chenxu1986
Hello, I have encountered the same problem. Have you solved it?

[yqw570994511]

@chenxu1986 Hello, I have encountered the same problem. Have you solved it?

Could you provide a test code for me to try and help you

[huicunjun]

@chenxu1986 Hello, I have encountered the same problem. Have you solved it?

Could you provide a test code for me to try and help you

gateway4.1.5，lb to SpringBoot 3.3.4 application，The link will be lost，traceid is not strung together

[huicunjun]

@chenxu1986 Hello, I have encountered the same problem. Have you solved it?

Could you provide a test code for me to try and help you

The local environment is easy to test, just like the main question, because the gateway link was interrupted prematurely, two traceids were generated, and the downstream service regenerated one traceid

[chenbihao]

@chenxu1986 Hello, I have encountered the same problem. Have you solved it?

Could you provide a test code for me to try and help you

maybe you can try this repo: gateway demo

[yqw570994511]

@chenxu1986 Hello, I have encountered the same problem. Have you solved it?

Could you provide a test code for me to try and help you

The local environment is easy to test, just like the main question, because the gateway link was interrupted prematurely, two traceids were generated, and the downstream service regenerated one traceid

This issue began to occur with gateway versions >= 4.1.2. Currently, I have not found a good way to handle this issue

[yqw570994511]

I have found a solution to address the tracking issue in versions above 4.1.2.

Use gateway4.1.5，lb to SpringBoot 3.3.4 application

The result is as follows:

[H2hong]

Is there no other solution?
I need to downgrade the version to gateway4.1.1+springboot3.2.12 for it to work properly

[yqw570994511]

To solve this problem, I plan to provide the following solutions by adding a new plugin: apm-spring-cloud-gateway-4.1.2.x-plugin ,see the link:#12925