diff --git a/src/main/java/org/apache/commons/mail/Email.java b/src/main/java/org/apache/commons/mail/Email.java index 3164ebde1..623966338 100644 --- a/src/main/java/org/apache/commons/mail/Email.java +++ b/src/main/java/org/apache/commons/mail/Email.java @@ -1417,7 +1417,6 @@ else if (this.emailBody != null) this.toInternetAddressArray(this.replyList)); } - if (!this.headers.isEmpty()) { for (final Map.Entry entry : this.headers.entrySet()) diff --git a/src/main/java/org/apache/commons/mail/EmailConstants.java b/src/main/java/org/apache/commons/mail/EmailConstants.java index ad776a017..64fa3161a 100644 --- a/src/main/java/org/apache/commons/mail/EmailConstants.java +++ b/src/main/java/org/apache/commons/mail/EmailConstants.java @@ -240,7 +240,6 @@ public final class EmailConstants */ public static final String MAIL_FROM = "mail.from"; - /** Hide constructor. */ private EmailConstants() { diff --git a/src/main/java/org/apache/commons/mail/HtmlEmail.java b/src/main/java/org/apache/commons/mail/HtmlEmail.java index 512d3c16c..b3e4e9eab 100644 --- a/src/main/java/org/apache/commons/mail/HtmlEmail.java +++ b/src/main/java/org/apache/commons/mail/HtmlEmail.java @@ -90,7 +90,6 @@ public class HtmlEmail extends MultiPartEmail /** suffix for default HTML mail. */ private static final String HTML_MESSAGE_END = ""; - /** * Text part of the message. This will be used as alternative text if * the email client does not support HTML messages. diff --git a/src/test/java/org/apache/commons/mail/EmailTest.java b/src/test/java/org/apache/commons/mail/EmailTest.java index d97068f09..0ea809954 100644 --- a/src/test/java/org/apache/commons/mail/EmailTest.java +++ b/src/test/java/org/apache/commons/mail/EmailTest.java @@ -691,7 +691,6 @@ public void testAddBcc2() throws Exception final String[] testEmailNames = {"Name1", "", null}; - final List arrExpected = new ArrayList<>(); arrExpected.add(new InternetAddress("me@home.com", "Name1")); arrExpected.add(new InternetAddress("joe.doe@apache.org")); diff --git a/src/test/java/org/apache/commons/mail/InvalidInternetAddressTest.java b/src/test/java/org/apache/commons/mail/InvalidInternetAddressTest.java index 3c609de7b..272f9780f 100644 --- a/src/test/java/org/apache/commons/mail/InvalidInternetAddressTest.java +++ b/src/test/java/org/apache/commons/mail/InvalidInternetAddressTest.java @@ -97,7 +97,6 @@ public void testStrictConstructor() throws Exception // Prove InternetAddress constructor is throwing exception. // ==================================================================== - // test Invalid Email addresses for (int i = 0; i < ARR_INVALID_EMAILS.length; i++) { diff --git a/src/test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java b/src/test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java index d05a7544f..d97e2ebd1 100644 --- a/src/test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java +++ b/src/test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java @@ -65,7 +65,6 @@ public void testNonIDNEmailAddressToAsciiConversion() assertEquals("me@home.com", idnEmailConverter.toASCII("me@home.com")); } - @Test public void testInternetAddressToAsciiConversion() throws Exception {