Confict between inline-env-var and command-instead-of-shell

[ioah86]

Summary

It appears that the remediation to one issue is causing the rise of a different one.
For the Rule inline-env-var in the current version,
the recommended correction is using ansible.builtin.shell instead of ansible.builtin.command. But the rule command-instead-of-shell requires to use command. Hence, the recommendations should not use ansible.builtin.shell for the correct code or at least include an example using purely ansible.builtin.command.

Issue Type

• Bug Report

OS / ENVIRONMENT

N/A

STEPS TO REPRODUCE

Read the documentation for inline-env-var and then also read the documentation for command-instead-of-shell. The "fixes" for inline-env-var violate command-instead-of-shell.

Desired Behavior

The recommended and documented fix for one issue should not violate another issue.

Actual Behavior

The recommended and documented fix for one issue should violates another issue.

[ssbarnea]

This is mostly an incomplete documentation issue because inline-env-var can be sorted in two ways:

• move the env vars into environment and still use command
• switch to shell but you will also have to disable the other rule command-instead-of-shell

A PR to improve docs here would be appreciated.

[ioah86]

Okay, so these are the two options then. I was wondering if there are other ways. The second one seems a bit unclean to be part of the official doc. I am happy to create a PR with the first option.