Remove is prefix from boolean properties

[carlos-menezes]

This is a pet peeve of mine. I'm trying out the new module and I'm not a huge fan of prefixing booleans with is. Also, class boolean properties which are Readonly<T> are prefixed with is (I assume to let the user differentiate between mutable and non-mutable properties), but the constructors to said classes take arguments that don't follow this logic:

const view = alt.WebView.create({
  url: 'http://assets/web/index.html',
  isVisible: true, // mutable property, has prefix
});

view.visible = true; // property visible is mutable, no prefix

I am suggesting we only change the values passed to ClassTemplate::Method as I believe it is a common convention to prefix booleans with is in C++.

Thoughts?

[xLuxy]

I personally like to use the prefix is for imutable boolean values. However, in JS i kinda feel like we shouldn't really do that at all and just remove the is prefix entirely

[xxshady]

i'm for is prefix for immutable properties

[carlos-menezes]

I believe the Readonly<T> conveys that idea very well in TypeScript, but I also understand that it may be a convention to keep. Whatever route to follow, just follow it consistently.

Either way, I would like to work on this issue to get some exposure to contributing to Alt:V, if possible.

[xLuxy]

I believe the Readonly<T> conveys that idea very well in TypeScript, but I also understand that it may be a convention to keep. Whatever route to follow, just follow it consistently.

Either way, I would like to work on this issue to get some exposure to contributing to Alt:V, if possible.

Sure, i'll assign you to that - feel free to make a PR - for any questions feel free to reach out to me on discord: xLuxy

[xLuxy]

@carlos-menezes what's the current state on this? You had closed #192

[carlos-menezes]

@carlos-menezes what's the current state on this? You had closed #192

Merged here: #202