Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in changes from forks #89

Open
alexdresko opened this issue Sep 2, 2018 · 4 comments
Open

Bring in changes from forks #89

alexdresko opened this issue Sep 2, 2018 · 4 comments

Comments

@alexdresko
Copy link
Owner

alexdresko commented Sep 2, 2018

Summary

Looks like @zimmer62 forked and didn't PR back to this repo. It would help if someone could determine if the changes need to be brought back into this repo. And, if so, create the PR. Here's the link to his commit:

zimmer62@356e0eb

@alekslyse
Copy link

From what I can see you already pulled Connector.cs (btw, thats also related to to issues with the "Test Plugin" cmd writeline so maybe remove that line

The other one since its just to small changes so should not be a large change?

@alexdresko
Copy link
Owner Author

@alekslyse I spent some time really looking at his code, and I think I've extracted the goal of his changes. Don't really know why he wanted those properties public, but I'm fine with it. See #94 if you'd like to provide feedback. @zshall will also review the PR before it gets merged.

@zimmer62
Copy link

zimmer62 commented Sep 5, 2018

I don't have any memory of what or why I made any changes. I thought we talked about it, but it was a lifetime ago for me.

@alexdresko
Copy link
Owner Author

No worries. I think I figured it out. Just duking it out with @zshall over some variable naming. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants