Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jansi dependency, or only depend on jansi-windows64 / jansi-native #1

Open
alexarchambault opened this issue Jan 28, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@alexarchambault
Copy link
Owner

alexarchambault commented Jan 28, 2020

The jansi JAR, that windows-ansi depends on, weights about 280 kB (and has no dependency).

windows-ansi ought to work fine with just jansi-native (for the Kernel32 class) along with jansi-windows64 (for its jansi.dll, the only native library we're interested in here). That should squeeze its dependencies weight down to ~57 kB:

$ ls -lh $(cs fetch org.fusesource.jansi:jansi-native:1.8 org.fusesource.jansi:jansi-windows64:1.8)
-rw-r--r--  1 alexandre  staff    21K  2 fév  2018 …/https/repo1.maven.org/maven2/org/fusesource/hawtjni/hawtjni-runtime/1.16/hawtjni-runtime-1.16.jar
-rw-r--r--  1 alexandre  staff    23K  2 fév  2018 …/https/repo1.maven.org/maven2/org/fusesource/jansi/jansi-native/1.8/jansi-native-1.8.jar
-rw-r--r--  1 alexandre  staff    13K  2 fév  2018 …/https/repo1.maven.org/maven2/org/fusesource/jansi/jansi-windows64/1.8/jansi-windows64-1.8.jar

These could even be merged into the windows-ansi JAR, but they might conflict with the actual jansi JARs if our users depend on them.

@alexarchambault alexarchambault changed the title Remove jansi dependency, or only depend on jansi-windows64 Remove jansi dependency, or only depend on jansi-windows64 / jansi-native Jan 28, 2020
@alexarchambault alexarchambault added the enhancement New feature or request label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant