Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of Jar extraction #4

Open
NoxHarmonium opened this issue Sep 17, 2019 · 0 comments
Open

Improve efficiency of Jar extraction #4

NoxHarmonium opened this issue Sep 17, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@NoxHarmonium
Copy link
Contributor

The way it works right now, every time a call is made to extract a file from a Jar, the whole Jar file has to be streamed.

https://github.com/agiledigital/mule-metadata-extractor/blob/master/src/mule_preview/tools/zip_utils.clj#L24

The only reason this isn't prohibitively slow is because of the OS file cache. All the Jars get loaded into the file cache and are accessed from memory. You notice this when running the tool for the first time and cache isn't populated.

It would be much more efficient to get a list of files to extract from a Jar and stream the Jar file once.

@NoxHarmonium NoxHarmonium added the enhancement New feature or request label Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant