Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings do not fail with invalid credentials #71

Open
dimitraz opened this issue Jun 12, 2018 · 2 comments
Open

Bindings do not fail with invalid credentials #71

dimitraz opened this issue Jun 12, 2018 · 2 comments

Comments

@dimitraz
Copy link

Description
If the Android or iOS credentials passed in at the bind step are invalid, there is no validation and the binding does not fail. However it will not show up in the Mobile App's JSON config.

@dimitraz
Copy link
Author

ping @pb82

@pb82
Copy link
Contributor

pb82 commented Jun 12, 2018

@dimitraz It's currently not possible to fail the binding as long is this issue on the ASB side is not resolved: openshift/ansible-service-broker#941

The variant config does not show up because UPS itself will not create a variant when the parameters are invalid and the config operator will not annotate the mobile client when it doesn't get a variant from UPS.

Error handling was implemented in #53 but had to be removed because of the issue linked above. Maybe it's worth retesting this with the latest ASB versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants