Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record videos at any duration #291

Open
MrRafael-dev opened this issue Jan 9, 2022 · 5 comments
Open

Record videos at any duration #291

MrRafael-dev opened this issue Jan 9, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@MrRafael-dev
Copy link
Contributor

Currently, it's possible to record only 4 seconds of gameplay. You hit F10 once, and it will automatically generate one webm file.
This is being handled here, at line 148.

It would be cool if we could record longer videos, though. So I think video recording could be done like this:

  1. Press F10 once.
  2. Gameplay is now being recorded. We could set some sort of indicator on top of the screen, so you don't forget to stop the recording later.
  3. Press F10 again, and it will immediately stop the recording and generate one webm file for you.
  4. If you forget to press F10 again, the recording will stop after a certain time limit (30 seconds?).
@christopher-kleine
Copy link
Contributor

Aside from Point 4, I agree with you there. But I tried this once. Kinda. I increased the duration from 4 to .. I think 30 seconds.
The video quality got real bad then. It was completely unusable. But it's totally possible I screwed up somewhere.

@aduros
Copy link
Owner

aduros commented Jan 10, 2022

For background, the reason this feature exists is because it was originally planned to have short gameplay preview thumbnails on the Play page at wasm.org. I want to redesign the Play page at some point (especially now that we have more games!), and maybe implement that idea.

@christopher-kleine
Copy link
Contributor

While you're at it, I think we should add categories or something like that.

@aduros
Copy link
Owner

aduros commented Jan 10, 2022

I'll create a new issue about redesigning the Play page, I didn't want to hijack this issue but just give some context 😃 Being able to record longer videos would be cool.

@TLAlice
Copy link

TLAlice commented Jan 11, 2022

Changed it to work that way in #301. I'm not very familiar with JS and this is my first contribution so I'm not sure if I did anything wrong but it did work while I was testing it.

@aduros aduros added the enhancement New feature or request label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants