From b36a07f9888851228fb02cc16fc90cbd19a52ec5 Mon Sep 17 00:00:00 2001
From: Dejan Preradovic <cod47516@adobe.com>
Date: Wed, 11 Sep 2024 15:36:49 +0200
Subject: [PATCH 1/2] MWPW-157753 - make only edit profile anchor clickable

---
 .../features/profile/dropdown.css             |  7 ++++++-
 .../features/profile/dropdown.js              | 20 ++++++++++---------
 .../partners-navigation.css                   |  4 +++-
 3 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/edsdme/blocks/partners-navigation/features/profile/dropdown.css b/edsdme/blocks/partners-navigation/features/profile/dropdown.css
index 04d02a7..9424d40 100644
--- a/edsdme/blocks/partners-navigation/features/profile/dropdown.css
+++ b/edsdme/blocks/partners-navigation/features/profile/dropdown.css
@@ -42,6 +42,9 @@
 .feds-profile-header .feds-profile-img {
   max-height: 64px;
   max-width: 64px;
+
+  /* MWPW-157753 - profile image should not be clickable */
+  pointer-events: none;
 }
 
 .feds-profile-details {
@@ -72,7 +75,9 @@
   margin: 0;
   font-size: 14px;
   text-decoration: underline;
-  color: var(--feds-color-profile);
+
+  /* MWPW-157753 - to meet requirements */
+  color: var(--link-color);
 }
 
 .feds-local-menu {
diff --git a/edsdme/blocks/partners-navigation/features/profile/dropdown.js b/edsdme/blocks/partners-navigation/features/profile/dropdown.js
index 07423b2..7e55802 100644
--- a/edsdme/blocks/partners-navigation/features/profile/dropdown.js
+++ b/edsdme/blocks/partners-navigation/features/profile/dropdown.js
@@ -2,6 +2,7 @@ import { toFragment, getFedsPlaceholderConfig, trigger, closeAllDropdowns, logEr
 
 // Partners navigation
 import { getLibs } from '../../../../scripts/utils.js';
+
 const miloLibs = getLibs();
 const { replaceKeyArray } = await import(`${miloLibs}/features/placeholders.js`);
 const { getConfig } = await import(`${miloLibs}/utils/utils.js`);
@@ -130,22 +131,23 @@ class ProfileDropdown {
       tabindex="0"
       alt="${this.placeholders.profileAvatar}"
       data-url="${decorateEditProfileLink()}"></img>`;
+    // MWPW-157753 - only Edit user profile link should be clickable
     return toFragment`
       <div id="feds-profile-menu" class="feds-profile-menu">
-        <a
-          href="${decorateEditProfileLink()}"
-          target="_blank"
-          class="feds-profile-header"
-          daa-ll="${this.placeholders.viewAccount}"
-          aria-label="${this.placeholders.editProfile}"
-        >
+        <div class="feds-profile-header">
           ${this.avatarElem}
           <div class="feds-profile-details">
             <p class="feds-profile-name">${this.profileData.displayName}</p>
             <p class="feds-profile-email">${this.decorateEmail(this.profileData.email)}</p>
-            <p class="feds-profile-account">${this.placeholders.editProfile}</p>
+            <a href="${decorateEditProfileLink()}"
+                target="_blank" 
+                daa-ll="${this.placeholders.viewAccount}"
+                aria-label="${this.placeholders.editProfile}" 
+                class="feds-profile-account">
+                    ${this.placeholders.editProfile}
+            </a>
           </div>
-        </a>
+        </div>
         ${this.localMenu ? this.decorateLocalMenu() : ''}
         <ul class="feds-profile-actions">
           ${this.sections?.manage?.items?.team?.id ? decorateAction(this.placeholders.manageTeams, '/team') : ''}
diff --git a/edsdme/blocks/partners-navigation/partners-navigation.css b/edsdme/blocks/partners-navigation/partners-navigation.css
index cf32fe3..c7012ad 100644
--- a/edsdme/blocks/partners-navigation/partners-navigation.css
+++ b/edsdme/blocks/partners-navigation/partners-navigation.css
@@ -3,8 +3,10 @@
   list-style-type: none;
 }
 
+/* MWPW-157753 */
 .global-navigation a:hover {
-  text-decoration: none;
+  text-decoration: underline;
+  color: var(--link-color);
 }
 
 .global-navigation button {

From aea1364459700dd97a6cdc0780e1d0a948fe1711 Mon Sep 17 00:00:00 2001
From: Dejan Preradovic <cod47516@adobe.com>
Date: Thu, 12 Sep 2024 11:49:58 +0200
Subject: [PATCH 2/2] MWPW-157751 - update comments

---
 .../partners-navigation/features/profile/dropdown.js  |  8 ++++----
 .../blocks/partners-navigation/partners-navigation.js | 11 ++++++-----
 .../blocks/partners-navigation/utilities/utilities.js |  5 +++--
 3 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/edsdme/blocks/partners-navigation/features/profile/dropdown.js b/edsdme/blocks/partners-navigation/features/profile/dropdown.js
index 7e55802..7037d3c 100644
--- a/edsdme/blocks/partners-navigation/features/profile/dropdown.js
+++ b/edsdme/blocks/partners-navigation/features/profile/dropdown.js
@@ -1,6 +1,6 @@
 import { toFragment, getFedsPlaceholderConfig, trigger, closeAllDropdowns, logErrorFor } from '../../utilities/utilities.js';
 
-// Partners navigation
+// MWPW-157751
 import { getLibs } from '../../../../scripts/utils.js';
 
 const miloLibs = getLibs();
@@ -93,7 +93,7 @@ class ProfileDropdown {
         this.placeholders.profileAvatar,
       ],
       [
-        this.placeholders.editProfile, // Partners navigation
+        this.placeholders.editProfile, // MWPW-157751
       ],
       { displayName: this.profileData.displayName, email: this.profileData.email },
     ] = await Promise.all([
@@ -101,7 +101,7 @@ class ProfileDropdown {
         ['profile-button', 'sign-out', 'view-account', 'manage-teams', 'manage-enterprise', 'profile-avatar'],
         getFedsPlaceholderConfig(),
       ),
-      // Partners navigation
+      // MWPW-157751
       replaceKeyArray(
         ['edit-profile'],
         getConfig(),
@@ -116,7 +116,7 @@ class ProfileDropdown {
   }
 
   decorateDropdown() {
-    // Partners navigation
+    // MWPW-157751
     // const { locale } = getConfig();
     // const lang = getLanguage(locale.ietf);
     // End
diff --git a/edsdme/blocks/partners-navigation/partners-navigation.js b/edsdme/blocks/partners-navigation/partners-navigation.js
index 2306f00..40b9a77 100644
--- a/edsdme/blocks/partners-navigation/partners-navigation.js
+++ b/edsdme/blocks/partners-navigation/partners-navigation.js
@@ -32,8 +32,9 @@ import {
   darkIcons,
 } from './utilities/utilities.js';
 
-// Partners navigation
-import { getLibs } from '../../scripts/utils.js'; // Partners navigation
+// MWPW-157751
+import { getLibs } from '../../scripts/utils.js'; // MWPW-157751
+
 const miloLibs = getLibs();
 const {
   getConfig,
@@ -425,7 +426,7 @@ class Gnav {
         if (!this.useUniversalNav) {
           const [ProfileDropdown] = await Promise.all([
             loadBlock('../features/profile/dropdown.js'),
-            loadStyles('/edsdme/blocks/partners-navigation/features/profile/dropdown.css') // Partners navigation
+            loadStyles('/edsdme/blocks/partners-navigation/features/profile/dropdown.css'), // MWPW-157751
           ]);
           this.ProfileDropdown = ProfileDropdown;
         }
@@ -1034,8 +1035,8 @@ export default async function init(block) {
     const url = await getSource();
     let content = await fetchAndProcessPlainHtml({ url });
     if (!content) return null;
-    block.classList.add('global-navigation'); // Partners navigation
-    content = applyGnavPersonalization(content); // Partners navigation
+    block.classList.add('global-navigation'); // MWPW-157751
+    content = applyGnavPersonalization(content); // MWPW-157751
     const gnav = new Gnav({
       content,
       block,
diff --git a/edsdme/blocks/partners-navigation/utilities/utilities.js b/edsdme/blocks/partners-navigation/utilities/utilities.js
index bef65af..b156eac 100644
--- a/edsdme/blocks/partners-navigation/utilities/utilities.js
+++ b/edsdme/blocks/partners-navigation/utilities/utilities.js
@@ -1,5 +1,6 @@
-// Partners navigation
+// MWPW-157751
 import { getLibs } from '../../../scripts/utils.js';
+
 const miloLibs = getLibs();
 const {
   getConfig, getMetadata, loadStyle, loadLana, decorateLinks, localizeLink,
@@ -337,7 +338,7 @@ export async function fetchAndProcessPlainHtml({ url, shouldDecorateLinks = true
   }
   const inlineFrags = [...body.querySelectorAll('a[href*="#_inline"]')];
   if (inlineFrags.length) {
-    const { default: loadInlineFrags } = await import(`${miloLibs}/blocks/fragment/fragment.js`); // Partners navigation
+    const { default: loadInlineFrags } = await import(`${miloLibs}/blocks/fragment/fragment.js`); // MWPW-157751
     const fragPromises = inlineFrags.map((link) => {
       link.href = getFederatedUrl(localizeLink(link.href));
       return loadInlineFrags(link);