Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodel_templates.py typo / error path #81

Open
yulmijoa opened this issue Dec 17, 2024 · 1 comment
Open

submodel_templates.py typo / error path #81

yulmijoa opened this issue Dec 17, 2024 · 1 comment
Labels
SMT Issues related to SMT validation

Comments

@yulmijoa
Copy link

yulmijoa commented Dec 17, 2024

  1. In submodel_templates.py, there is a typo that contains a blank.
  • typo in class DigitalNameplate
    manufacturer_product_root: Optional[LangString] = field(metadata={
    "semantic_id": " 0173-1#02-AAU732#001",
    })
  1. Why are the uris of id and semanticId/keys/value in the submodel object different? I know that semanticId/keys/value is ultimately used, but I wonder why id uses idta and value uses zvei.
    "id": "https://admin-shell.io/idta/SubmodelTemplate/DigitalNameplate/3/0",
    "kind": "Template",
    "semanticId": {
    "type": "ExternalReference",
    "keys": [
    {
    "type": "GlobalReference",
    "value": "https://admin-shell.io/zvei/nameplate/2/0/Nameplate"
    }
    ]
  2. I think the detailed {path} that is displayed when the constriant AASd-120 violated error occurs is incorrect. Please check it.
    Constraint AASd-120 violated: element 0 must not have an idShort @ /submodels/0/submodel_elements/18
    Constraint AASd-120 violated: element 0 must not have an idShort @ /submodels/0/submodel_elements/19/value/3
  • The exact location I found to resolve the error is
    submodels/0/submodel_elements/18/value/0/idShort
    submodels/0/submodel_elements/19/value/3/value/idShort
@yulmijoa yulmijoa changed the title submodel_templates.py typo and some questions submodel_templates.py typo / error path Dec 17, 2024
@juileetikekar juileetikekar added the SMT Issues related to SMT validation label Jan 13, 2025
@otto-ifak
Copy link
Collaborator

Hi @yulmijoa thanks for you feedback. I'll address the individual points:

  1. You are right (fixed in a8cfcc8)
  2. Where do you found this example?
  3. Can you provide a sample for this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SMT Issues related to SMT validation
Projects
None yet
Development

No branches or pull requests

3 participants