Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically lint csvs before concatenating #31

Open
avanlinden opened this issue Oct 23, 2023 · 2 comments
Open

automatically lint csvs before concatenating #31

avanlinden opened this issue Oct 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@avanlinden
Copy link
Contributor

avanlinden commented Oct 23, 2023

Things that can cause problems:

  • empty rows at the end of a csv
  • incorrect number of columns introduced (can catch with Rainbow "lint CSV" button but have to do manually)
  • using the "Align" feature in Rainbow for viewing and then not going back to "shrink" before saving. Introduces white space in columns and throws the whole thing off.

More model-specific but: should have a check that all attribute rows that are valid values of a parent attribute also appear in the list of values in the Valid Values column for their parent attribute. And also that all the values in the Valid Values column of the parent have a row attribute (less urgent than the reverse though).

Ideally should have some automated csv linting before the step where module csvs are concatenated into the main csv

@avanlinden avanlinden added the enhancement New feature or request label Oct 23, 2023
@avanlinden
Copy link
Contributor Author

also #82 type checking

@avanlinden
Copy link
Contributor Author

use pre-commit hooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant