-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] python 3.13.1 (vs 3.13.0): Defining iterator in a separate class no longer works in 3.13 #11241
Comments
Hi @HinTak We will look into the issue and keep you posted with updates. Thank You. |
@susmitamane looking at the CI logs more carefully, it seems that the regression is specific to python 3.13 (works on 3.10/3.11/3.12)- I.e. skia-python loaded via python 3.13 on Intel mac 13 can't access apple color emoji. Has anything changes between the two images regarding its python 3.13 installation? |
Okay, the two runs differ by the python version - it is 3.13.0 in the successful run but 3.13.1 in the broken run. |
Hi @HinTak
Thank you. |
@susmitamane thanks for your time. The skia.Iter code has not changed for at least 5 years, and the identical code works a few weeks ago (the two ci entry are simply one sync'ing the main of the other). Not sure why 3.13.0 to 3.13.1 on mac os x would break. Anyway, I am due to upgrade to 3.13.1 on my Linux desktop from 3.13.0 on the next reboot, too, so I should be able to tell whether 3.13.1 on Linux is affected. |
@susmitamane Just to let you know, I have upgraded python on my linux desktop to 3.13.1 from 3.13.0, and I can reproduce the issue on linux, so it is not specific for mac os x, but specific to 3.13.0 to 3.13.1 upgrade. Looking elsewhere, I think the issue is python/cpython#128161 . |
See python/cpython#128161 "Defining iterator in a separate class no longer works in 3.13" We have iterator for SkTextBlob defined by SkTextBlob::Iter(textblob), which is the c++/pybind11 equivalent of the same situation. Following the suggestion: python/cpython#128161 (comment) Also see actions/runner-images#11241 Fixes kyamagu#295
@susmitamane I am 100% sure the issue is python/cpython#128161 ; I shall let you to decide whether to close this, or leave this open so that other people having 3.13.0 to 3.13.1 problems can see an answer. |
. چه کسی می تواند از این ویژگی استفاده کند؟ |
Description
Have two identical ci, https://github.com/kyamagu/skia-python/actions/runs/11829956181
(Sync main of fork with upstream)
https://github.com/HinTak/skia-python/actions/runs/12487829150
The latter fails on Apple Color Emoji font being missing.
Platforms affected
Runner images affected
Image version and build link
Success:
Current runner version: '2.320.0'
Operating System
macOS
13.7.1
22H221
Runner Image
Image: macos-13
Version: 20241108.324
Included Software: https://github.com/actions/runner-images/blob/macos-13/20241108.324/images/macos/macos-13-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/macos-13%2F20241108.324
Runner Image Provisioner
2.0.384.1+6d6c56aa16f1b9c7dd7935df5d63980397e44def
Failure:
Current runner version: '2.321.0'
Operating System
macOS
13.7.2
22H313
Runner Image
Image: macos-13
Version: 20241216.479
Included Software: https://github.com/actions/runner-images/blob/macos-13/20241216.479/images/macos/macos-13-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/macos-13%2F20241216.479
Runner Image Provisioner
2.0.404.1+573eac7f0cc07d6bb82d8b9bf5e1ffa69a554644
Is it regression?
Yes
Expected behavior
The Apple Color Emoji font is exported to be installed.
Actual behavior
Cannot find the Emoji font from the system
Repro steps
See the CI entries.
The text was updated successfully, but these errors were encountered: