-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The polyfill functions in @paprika/helpers
should be in a separated package as a peer dependency
#937
Comments
I think would be better to have specific packages for polyfills? also we are no longer supporting ie11 🤔 would this still be relevant? |
Yeah we definitely don't need this after September, maybe we need some cleanup at that time |
@nahumzs that depends on a polyfill. We'll need to check the compatibility for each feature and decide if we still need some polyfills or not. |
@allison-c Do you think this is still needed? |
some of the polyfills are no longer need it if ie11 is not needed it, might as well be possible to just delete the polyfill for the newest versions. |
Hi @nahumzs LOL |
haha hi Nahum! |
Sounds like this is still relevant for cleaning up the polyfills! Will leave this :) |
Bug Report
E.g
elementScroll.js
is the polyfill forElement.scroll(), Element.scrollTo(), Element.scrollBy()
, but it's very common that a consuming app has paprika components in different ages, most of them will have different versions of@paprika/helpers
package, which means we'll have multiple versions ofelementScroll.js
.However, each polyfill is an IIFE, the later executed
elementScroll.js
will override the previous one.Element.scroll(), Element.scrollTo(), Element.scrollBy()
will keep changing until everything loaded and executed. It will be very hard to debug when needed.Expected behavior
Polyfills should be peer dependencies, or maybe because IE 11 will be unsupported soon, we can remove them?
Current behavior
Multiple versions of polyfills in consuming apps.
Screenshots / Gifs / Codepens
Include media to help illustrate the bug. Gifs help a lot!
Additional context
cc @AndreyChernykh
The text was updated successfully, but these errors were encountered: