Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible Segment optionally show the expand toggle #1227

Open
2 tasks
tristanjasper opened this issue Feb 4, 2022 · 0 comments
Open
2 tasks

Collapsible Segment optionally show the expand toggle #1227

tristanjasper opened this issue Feb 4, 2022 · 0 comments

Comments

@tristanjasper
Copy link
Contributor

Sometimes we need to render a collapsible section with 0 items in the body but still need the segment to show (eg if there is a button on it).
If that is the case I don't think we should render the expand toggle as it is misleading and doesnt' do anything. We could add a prop to teh segment to control if it is rendered or not

Eg for this ui on workflows
image

Feature request

Prerequisites

This is just a checklist, please delete this section after
Please answer the following questions for yourself before submitting a feature request.

  • I checked to make sure that this feature has not already been suggested
  • Please label as, low / medium / high priority

Please fill in as much detail as possible

Is your feature request related to a problem?

A clear and concise description of what the problem is

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant