Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubric and Summary #4

Open
ulisigi opened this issue Mar 2, 2019 · 0 comments
Open

Rubric and Summary #4

ulisigi opened this issue Mar 2, 2019 · 0 comments

Comments

@ulisigi
Copy link

ulisigi commented Mar 2, 2019

Rubric Score

Criteria 1: HTML Structure

  • Score Level: 4/4
  • Comment(s): HTML implementation enables proper use of flexbox.

HTML structure reflects the grouping and flow of content in the web browser.

Criteria 2: Visual Layout

  • Score Level: 3/4
  • Comment(s): Layout matches the design spec in 3-4 sections.

(This includes a sticky header w/ no gap between it and top of viewport )

Criteria 3: Use of Flexbox

  • Score Level: 4/4
  • Comment(s): Flexbox properties are correctly applied to flex containers and flex items throughout.

Flexbox is used properly and is the primary way of positioning.

Criteria 4: Implementation of Design Specification and Content

  • Score Level: 4/4
  • Comment(s): The page includes all style and content provided in the design specification.

(For example, anchor colors match the design spec.)

Overall Score: 15/16

Your project Exceeds Expectations - way to go! The layout and styling of this project is a big step up from the first one submitted for the course, and you did a great job of executing the implicit and explicit styling from the design specification. Nice use of comments in your HTML and CSS to help keep your code more easily readable. As the projects continue to grow larger and more complex, I recommend using more semantic elements like <section> and <article> to further improve readability, as well as improving accessibility and SEO of page.

Here's a reference for semantic elements:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element

Here's an article about semantic elements and accessibility:
https://24ways.org/2017/accessibility-through-semantic-html/

Overall, very nicely done on this project! If you haven't already done so, I suggest starting to build a personal site with the skills you've learned so far. This will not only be great extra practice of the skills you've already learned, but will also be a way to continue to practice the new things learned in the future Units (like mobile friendly design and layouts) and show off your skills with a portfolio when you've completed the course. Keep up the excellent work, and happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant